Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify params for Popupable trait without using any #777

Closed
jbphet opened this issue Jul 21, 2022 · 1 comment
Closed

Specify params for Popupable trait without using any #777

jbphet opened this issue Jul 21, 2022 · 1 comment
Labels
help-wanted

Comments

@jbphet
Copy link
Contributor

jbphet commented Jul 21, 2022

In phetsims/chipper#1253 we are adding a lint rule that, for the most part, forbid the use of the any type specification. The Popupable.ts file is using any in its constructor so that it can work well with the other classes with which it is combined. I don't have any idea how to make this more type-specific, so I'm going to add a comment that will tell lint to ignore this for now and assign to one of the original authors.
jbphet added a commit that referenced this issue Jul 21, 2022
@jbphet
disable lint for any, add TODO, see #777
05ff864
@jbphet jbphet changed the title Specify params for Pupupable trait without using any Specify params for Popupable trait without using any Jul 21, 2022
@marlitas marlitas mentioned this issue Oct 30, 2023
Open
samreid added a commit that referenced this issue Dec 9, 2024
@samreid
Change any to IntentionalAny, see #777
1f4a59b
@samreid
Copy link
Member

samreid commented Dec 9, 2024

constructor any array is idiomatic for our mixin pattern, closing.

@samreid samreid closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samreid @jbphet @marlitas