-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address TODO about propagating options to button model. #749
Comments
It's not really clear what the TODO means here, @pixelzoom or @jonathanolson can you clarify? |
Passing the same options to 50 const pushButtonModel = new PushButtonModel( superOptions );
51
52 super( pushButtonModel, new PushButtonInteractionStateProperty( pushButtonModel ), superOptions ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This NOTE was added by @jonathanolson when he converted RectangularPushButton to TypeScript. It should have been a TODO, with an issue. The same problem needs to be addressed in RoundPushButton, and any other sun button that propagates all of its options to its model class. It's unlikely that there's a TODO in every location where this needs to be addressed.
The text was updated successfully, but these errors were encountered: