Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve return type for rasterize #1682

Open
samreid opened this issue Feb 5, 2025 · 4 comments
Open

Improve return type for rasterize #1682

samreid opened this issue Feb 5, 2025 · 4 comments
Assignees
@jonathanolson
Labels
status:ready-for-review

Comments

@samreid
Copy link
Member

samreid commented Feb 5, 2025

We had a ts-expect-error in membrane channels because rasterize didn't know that wrap: false returns Image. Fix inbound.
@samreid samreid self-assigned this Feb 5, 2025
samreid added a commit to phetsims/membrane-channels that referenced this issue Feb 5, 2025
@samreid
Add overload signatures for rasterize, and convert to function, see p…
17cfaf2 
…hetsims/scenery#1682
samreid added a commit that referenced this issue Feb 5, 2025
@samreid
Add overload signatures for rasterize, and convert to function, see #…
0ce4d1e 
…1682
@samreid
Copy link
Member Author

samreid commented Feb 5, 2025

@jonathanolson @jessegreenberg or @zepumph can you please spot check review?

@zepumph
Copy link
Member

zepumph commented Feb 5, 2025

Very nice stuff! Looks very similar to what we did in execute(), and that is working very very well (I'm often surprised and impressed). No notes.

@jonathanolson
Copy link
Contributor

I like it, thanks!

@jonathanolson
Copy link
Contributor

I'll need to adjust scenerystack to handle the seemingly multiple-exported function, will have commits incoming here.

jonathanolson added a commit to scenerystack/scenerystack that referenced this issue Feb 5, 2025
@jonathanolson
Filter out duplicate export entries, see phetsims/scenery#1682
8fa4d6f
@samreid samreid assigned jonathanolson and unassigned samreid Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonathanolson @samreid @jessegreenberg @zepumph