-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to limit the ParallelDOM API to just accessibleName and helpText #1666
Comments
I added a parametric type called export type ABSwitchOptions = TrimmedParallelDOMOptions<SelfOptions & HBoxOptions>; @pixelzoom can you please review this, what are your thoughts about using this in common code to constrain the API? |
Re I pointed out that Node handles this a bit differently. It exports subsets of options, like I'm unsure whether 1 subset of high-level options (currently I'm unsure if |
Thanks for the thoughts here @pixelzoom, I considered these a bit more.
Doing it this way will be difficult because
Yes, we will probably need others, but I think this is the right starting set for UI components as we scale out accessible names and help text. Variations can include or omit things as they need and if a pattern forms we can create a new subset.
Good point, Ill rename it to |
The rename is done. Closing. |
Many components will should only allow setting
accessibleName
andhelpText
of ParallelDOM options. Lets use TypeScript to make this clear. I am imagining a type that will basically omit all ParallelDOMOptions except for these two.The text was updated successfully, but these errors were encountered: