Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createGatedVisibleProperty should be a Class #1641

Closed
zepumph opened this issue Jul 1, 2024 · 3 comments
Closed

createGatedVisibleProperty should be a Class #1641

zepumph opened this issue Jul 1, 2024 · 3 comments
Assignees
@samreid
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Jul 1, 2024

Promoting TODO, and part of buoyancy code review.
zepumph added a commit that referenced this issue Jul 1, 2024
@zepumph
promote TODO: #1641
75c54a2 
Signed-off-by: Michael Kauzmann <[email protected]>
@zepumph zepumph self-assigned this Jul 8, 2024
@zepumph
Copy link
Member Author

zepumph commented Jul 8, 2024

From buoyancy design meeting today, we could use this for greenhouse in the cloud checkbox.

zepumph added a commit to phetsims/greenhouse-effect that referenced this issue Jul 9, 2024
@zepumph
convert to GatedVisibleProperty, phetsims/scenery#1641
e7f56ba 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/mean-share-and-balance that referenced this issue Jul 9, 2024
@zepumph
convert createGatedVisibleProperty to a class, phetsims/scenery#1641
a9e50f2 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Jul 9, 2024
@zepumph
convert createGatedVisibleProperty to a class, phetsims/scenery#1641
3e38ed6 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/center-and-variability that referenced this issue Jul 9, 2024
@zepumph
convert createGatedVisibleProperty to a class, phetsims/scenery#1641
01e4c1e 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/projectile-data-lab that referenced this issue Jul 9, 2024
@zepumph
convert createGatedVisibleProperty to a class, phetsims/scenery#1641
ef82153 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit that referenced this issue Jul 9, 2024
@zepumph
convert createGatedVisibleProperty to a class, #1641
c3bece4 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit that referenced this issue Jul 9, 2024
@zepumph
fix type problems, #1641
a38712b 
Signed-off-by: Michael Kauzmann <[email protected]>
@zepumph
Copy link
Member Author

zepumph commented Jul 9, 2024

I feel pretty confident about this change, as it was mostly just a conversion to a class, but I also updated to use optionize, and changed the greenhouse effect usage + migration rule. @samreid can you please spot check?

@zepumph zepumph removed their assignment Jul 9, 2024
zepumph added a commit to phetsims/axon that referenced this issue Nov 26, 2024
@zepumph
convert createGatedVisibleProperty to a class, phetsims/scenery#1641
aec82a9 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/axon that referenced this issue Nov 26, 2024
@zepumph
fix type problems, phetsims/scenery#1641
8782252 
Signed-off-by: Michael Kauzmann <[email protected]>
@samreid samreid self-assigned this Dec 31, 2024
@samreid
Copy link
Member

samreid commented Dec 31, 2024

Looks great, nice work. Closing.

@samreid samreid closed this as completed Dec 31, 2024
samreid added a commit to phetsims/axon that referenced this issue Jan 1, 2025
@samreid
Add tests, see phetsims/scenery#1641
d72042f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph