Skip to content

Commit

Permalink
strings are not translatable until solid, see phetsims/greenhouse-eff…
Browse files Browse the repository at this point in the history
  • Loading branch information
jessegreenberg committed Aug 4, 2022
1 parent 889eab0 commit 9c959e3
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 22 deletions.
8 changes: 4 additions & 4 deletions js/keyboard/help/TimingControlsKeyboardHelpSection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
import optionize from '../../../../phet-core/js/optionize.js';
import sceneryPhet from '../../sceneryPhet.js';
import KeyboardHelpSection, { KeyboardHelpSectionOptions } from './KeyboardHelpSection.js';
import sceneryPhetStrings from '../../sceneryPhetStrings.js';

// constants
const timingControlsString = sceneryPhetStrings.keyboardHelpDialog.timingControls.timingControls;
const pauseOrPlayActionString = sceneryPhetStrings.keyboardHelpDialog.timingControls.pauseOrPlayAction;
const pauseOrPlayActionDescriptionString = sceneryPhetStrings.a11y.keyboardHelpDialog.timingControls.pauseOrPlayActionDescription;
// These are not translatable yet until we have decisions made in https://github.com/phetsims/greenhouse-effect/issues/194
const timingControlsString = 'Timing Controls';
const pauseOrPlayActionString = 'Pause or play action';
const pauseOrPlayActionDescriptionString = 'Pause or play action with alt key plus K.';

type SelfOptions = {

Expand Down
7 changes: 0 additions & 7 deletions js/sceneryPhetStrings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ type StringsType = {
'closeWithoutChanging': string;
'options': string;
'option': string;
};
'timingControls': {
'timingControls': string;
'pauseOrPlayAction': string;
}
};
'speed': {
Expand Down Expand Up @@ -167,9 +163,6 @@ type StringsType = {
'moveThroughPatternDescription': string;
'chooseNewPatternDescription': string;
'closeWithoutChangingDescription': string;
};
'timingControls': {
'pauseOrPlayActionDescription': string;
}
};
'playControlButton': {
Expand Down
11 changes: 0 additions & 11 deletions scenery-phet-strings_en.json
Original file line number Diff line number Diff line change
Expand Up @@ -194,12 +194,6 @@
"keyboardHelpDialog.comboBox.option": {
"value": "option"
},
"keyboardHelpDialog.timingControls.timingControls": {
"value": "Timing Controls"
},
"keyboardHelpDialog.timingControls.pauseOrPlayAction": {
"value": "Pause or play action"
},
"speed.normal": {
"value": "Normal"
},
Expand Down Expand Up @@ -382,11 +376,6 @@
"closeWithoutChangingDescription": {
"value": " Close list without changing with Escape key."
}
},
"timingControls": {
"pauseOrPlayActionDescription": {
"value": "Pause or play action with alt key plus K."
}
}
},
"playControlButton": {
Expand Down

0 comments on commit 9c959e3

Please sign in to comment.