-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VoiceOver] Object responses not heard with hand slider #530
Comments
Next steps are to try to reproduce this, and then make sure that it wasn't an issue with VO state as opposed to sim state. |
@marlitas and I discussed and investigated this a lot. Marla is on mac OS13.0 and was easily able to reproduce this bug.
No matter, I wonder how much more effort this issue is worth when I can't help but think that this is a safari bug introduced in OS13. @emily-phet can you please recommend if we should spend more time on this? Thanks! |
My recommendation is to close as a wont fix. |
I think we should confirm if this issue is present when the slider is accessed using the recommended key commands. If no issue is found then, let's close this as "won't fix". Responses are always sketchy when not using the recommended keyboard interactions. |
After doing some testing with @samreid, it looks like this bug is present in chrome on Mac OS13 also. We didn't experience any different/better behavior when "entering" the slider with "ctrl+option+shift+down arrow". @emily-phet from here we could either assume it will be fixed by apple at some point and do nothing, or try to investigate workarounds. What would you like to do? |
@emily-phet and I think the next steps here are to reach out to @jessegreenberg. |
I tested on macOS 11.7.2 and I was not able to produce the problem. Ill see if I can update and will try again. |
@jessegreenberg I think you need to be on macOS 13. |
Thanks @Nancy-Salpepi, unfortunately my Mac is from 2013 and cannot install macOS 13 according to https://support.apple.com/en-us/HT213264. Id like to see how these alerts work (aria-valuetext vs aria-live?) then try to reproduce in macOS 13 to isolate the problem. Then we can find a workaround or submit a bug report. |
From @jessegreenberg and my brainstorm:
|
@jessegreenberg and @Nancy-Salpepi and I made progress on this today. With the snippet below we were able to see that if the aria-live has a delay of 1000ms after the value changes, then we hear the aria-valuetext completely, but with no delay, or 250ms we didn't. Furthermore @Nancy-Salpepi and I saw the same behavior where runniong RAP with https://phet-dev.colorado.edu/html/jg-tests/tests/test.html Now that we understand that it is about timing, I feel like it is less likely that mac will think of it as a bug to fix, and we probably do want a workaround for it. <html>
<body>
<!--StartFragment-->
| <!DOCTYPE html>
-- | --
| <html>
| <head>
| <meta charset="UTF-8">
| <title>TEST PAGE</title>
| </head>
| <body>
|
| <input id="sim-slider" type="range" aria-orientation="vertical" aria-valuetext="hands, at challenge ratio" min="0"
| max="1" step="0.01" aria-valuenow="0.2" style="top: 0px; left: 0px; width: 1px; height: 1px;">
|
| <p aria-live="polite" id="my-alerter"></p>
| <input type="range" id="my-slider" min="1" max="10" step="1" aria-valuetext="My value: 5" value="8">
|
| </body>
|
| <script>
| // things to test
| // basic aria-valuetext
| // Add an interrupting aria-live alert
|
| const simSlider = document.getElementById( 'sim-slider' );
|
| const mySlider = document.getElementById( 'my-slider' );
| const myAlerter = document.getElementById( 'my-alerter' );
|
| mySlider.addEventListener( 'change', event => {
| mySlider.setAttribute( 'aria-valuetext', `My value: ${mySlider.value}` );
|
| window.setTimeout( () => {
| myAlerter.textContent = `You just change value to ${mySlider.value}`;
| }, 250 );
| } );
|
| simSlider.addEventListener( 'change', event => {
| simSlider.setAttribute( 'aria-valuetext', `My value: ${simSlider.value}` );
|
| window.setTimeout( () => {
| myAlerter.textContent = `You just change value to ${simSlider.value}`;
| }, 250 );
| } );
|
| </script>
| </html>
<!--EndFragment-->
</body>
</html> |
I don't think this issue is caused by the timing. More fundamentally, if <!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>TEST PAGE</title>
</head>
<body>
<p aria-live="polite" id="my-alerter"></p>
<input type="range" id="my-slider" min="1" max="10" step="1" aria-valuetext="My value: 5" value="8">
</body>
<script>
const mySlider = document.getElementById( 'my-slider' );
const myAlerter = document.getElementById( 'my-alerter' );
mySlider.addEventListener( 'change', event => {
mySlider.setAttribute( 'aria-valuetext', `My value: ${mySlider.value}` );
} );
let alertValue = 0;
window.setInterval( () => {
myAlerter.textContent = `Alert value is ${alertValue++}`;
}, 3000 );
</script>
</html> Even more fundamentally, it is buggy that VoiceOver in macOS 13 interrupts the If there is a workaround, I think it will be in the attributes/markup of the |
I submitted the bug report in phetsims/a11y-research#180. |
That makes a lot of sense! Thank you so much for your hard work investigating. |
Actually @jessegreenberg and @zepumph, the more I play with Friction, the more I think it is a slightly different issue. I hear the "more atoms break away" statement sometimes, but lots of times it gets completely skipped over. |
At this point I think we should close this issue since we have phetsims/a11y-research#180. Thanks all |
Test device
MacBook Air (m1 chip)
Operating System
macOS 13.0.1
Browser
safari 16.1
Problem description
For phetsims/qa#852:
With VoiceOver, it seems like object responses are being overwritten by context responses when moving one hand at a time. I am not hearing any changes to Challenge Ratio proximity. You can see at the start of the video that first time I move a hand, the response appears in the VO box, but it is never uttered and I never see the response again.
When both hands have focus and I move a hand, I do hear the object responses.
Met with @terracoda over Zoom to discuss. TS is not seeing this issue with macOS 12.1.1.
Steps to reproduce
Visuals
VOchallengeratio.mov
The text was updated successfully, but these errors were encountered: