Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic layout when PhET-iO hides all elements in a container #363

Open
zepumph opened this issue Jan 15, 2025 · 0 comments
Open

Comments

@zepumph
Copy link
Member

zepumph commented Jan 15, 2025

From https://github.com/phetsims/phet-io/issues/2003, there are cases that a new phet-io fuzzing feature exposed in this sim, where you could potentially be trying to layout a Node based on another Node with infinite bounds. It has infinite bounds because it has no visible children. Most cases are containers like a Panel with children that are exclusively PhET-iO instrumented elements with an instrumented visibleProperty.

To test the trouble, remove the isFinite() workaround next to the TODO pointing to this issue, run in studio, and hide all the children of the container that is being used in the layout code (right side of the equals sign in the layout code line).

This issue is likely best to be worked on next time this repo is in active development, but up to the responsible dev how to do the layout in this case.

zepumph added a commit that referenced this issue Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant