Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CODAP] Use the CODAP 'hidden' property to manage visibility of attribute columns #362

Open
matthew-blackman opened this issue Jan 15, 2025 · 1 comment

Comments

@matthew-blackman
Copy link
Contributor

In addressing issues #347 #360 #359 #357, I found that it was much more performant to update the 'hidden' property of CODAP attributes when a variable is checked/unchecked, so that the data table columns are not being rebuilt every time. This also cleans up the wrapper code and preserves the order of the columns, mapping them to the order of the checkboxes. Consulting with @samreid, it looks like this is a solid approach and will also improve our wrapper performance.

Note: This will also fix the 'Save a Copy' issue in #359.

@matthew-blackman
Copy link
Contributor Author

The above commits addressed several issues. Leaving this open until those issues are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant