Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat all code according to the PhET code style rules #155

Open
samreid opened this issue Feb 26, 2021 · 2 comments
Open

Reformat all code according to the PhET code style rules #155

samreid opened this issue Feb 26, 2021 · 2 comments
Labels
priority:5-deferred

Comments

@samreid
Copy link
Member

samreid commented Feb 26, 2021

From #150 (comment), and it is common that I make code changes and press reformat only to see many other spurious changes in the file. It seems we need to format the code, and a process to keep it formatted. I'll take an initial look.
@samreid samreid self-assigned this Feb 26, 2021
@samreid
Copy link
Member Author

samreid commented Feb 26, 2021

I made a fresh import of the webstorm rules, to make sure that I have the right style. I also checked Fourier and Natural Selection, and saw a minimal number of differences. I'm not sure what explains them--perhaps the code wasn't formatted before committing.

samreid added a commit to phetsims/fourier-making-waves that referenced this issue Feb 26, 2021
@samreid
Apply Webstorm formatting, see phetsims/phet-info#155
f49ea98
samreid added a commit to phetsims/natural-selection that referenced this issue Feb 26, 2021
@samreid
Apply Webstorm formatting, see phetsims/phet-info#155
1fb6eaf
samreid added a commit to phetsims/aqua that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
20f1968
samreid added a commit to phetsims/area-model-common that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
71e57b6
samreid added a commit to phetsims/area-builder that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
3295e1c
samreid added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
486f726
samreid added a commit to phetsims/calculus-grapher that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
8f55ffc
samreid added a commit to phetsims/collision-lab that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
b715d33
samreid added a commit to phetsims/fluid-pressure-and-flow that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
1bf7546
samreid added a commit to phetsims/build-an-atom that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
4fd5848
samreid added a commit to phetsims/capacitor-lab-basics that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
b71a34f
samreid added a commit to phetsims/build-a-molecule that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
a280d6a
samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
524b6ba
samreid added a commit to phetsims/gas-properties that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
0cf674c
samreid added a commit to phetsims/equality-explorer-basics that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
f729691
samreid added a commit to phetsims/bamboo that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
5c6222b
samreid added a commit to phetsims/dot that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
6c2c567
samreid added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
f526d41
samreid added a commit to phetsims/hookes-law that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
74a700e
samreid added a commit to phetsims/fractions-common that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
6c7acaf
samreid added a commit to phetsims/beers-law-lab that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
e0624ed
samreid added a commit to phetsims/density-buoyancy-common that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
3882302
samreid added a commit to phetsims/balloons-and-static-electricity that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
eead4e7
samreid added a commit to phetsims/graphing-lines that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
4c16049
samreid added a commit to phetsims/friction that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
3d8a3bb
samreid added a commit to phetsims/molecules-and-light that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
9128d36
samreid added a commit to phetsims/faradays-law that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
295e198
samreid added a commit to phetsims/nitroglycerin that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
03607c1
samreid added a commit to phetsims/perennial that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
0fe7a68
samreid added a commit to phetsims/kite that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
40d5bc5
samreid added a commit to phetsims/proportion-playground that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
4dc7167
samreid added a commit to phetsims/inverse-square-law-common that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
21f33ee
samreid added a commit to phetsims/molecule-shapes that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
9b9d385
samreid added a commit to phetsims/sun that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
721a0e6
samreid added a commit to phetsims/scenery that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
3438358
samreid added a commit to phetsims/rutherford-scattering that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
f870a81
samreid added a commit to phetsims/tandem that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
310f13f
samreid added a commit to phetsims/trig-tour that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
ad65d5c
samreid added a commit to phetsims/tambo that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
08f35f3
samreid added a commit to phetsims/states-of-matter that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
bcab176
samreid added a commit to phetsims/phetcommon that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
b4bedf8
samreid added a commit to phetsims/ph-scale that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
8f1d3d1
samreid added a commit to phetsims/shred that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
5c974f3
samreid added a commit to phetsims/tappi that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
58f1dca
samreid added a commit to phetsims/phet-core that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
8e51839
samreid added a commit to phetsims/scenery-phet that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
65aedef
samreid added a commit to phetsims/unit-rates that referenced this issue Feb 26, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
505a913
@samreid
Copy link
Member Author

samreid commented Feb 26, 2021

I applied formatting to js directories in our repos. I used this custom scope (specific to my paths), it excludes phet-io-website

file[apache-document-root]:main/*/js//*&&!file[apache-document-root]:main/phet-io-website/root//*

I'll set a calendar reminder to run this again in a month, deferring until then.

@samreid samreid removed their assignment Feb 26, 2021
@samreid samreid mentioned this issue Feb 26, 2021
Closed
samreid added a commit to phetsims/scenery that referenced this issue Mar 11, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
02013f7
samreid added a commit to phetsims/rutherford-scattering that referenced this issue Mar 11, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
f0a654f
samreid added a commit to phetsims/inverse-square-law-common that referenced this issue Mar 11, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
48383ef
samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Apr 1, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
91a4154
samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Apr 1, 2021
@samreid
Apply WebStorm formatting, see phetsims/phet-info#155
f6b1624
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
@samreid @jessegreenberg
Apply WebStorm formatting, see phetsims/phet-info#155
72ff486
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
@samreid @jessegreenberg
Apply WebStorm formatting, see phetsims/phet-info#155
33f0fd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:5-deferred
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samreid