Update eslint.config.mjs for browser vs node, see phetsims/chipper#1463

phetsims · Oct 22, 2024 · 4926a28 · 4926a28
1 parent e00bc4e
commit 4926a28
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 45 deletions.
diff --git a/eslint/buildtools.eslint.config.mjs b/eslint/buildtools.eslint.config.mjs
diff --git a/eslint/chipper.eslint.config.mjs b/eslint/chipper.eslint.config.mjs
diff --git a/eslint/node.eslint.config.mjs b/eslint/node.eslint.config.mjs
@@ -4,19 +4,39 @@
 import globals from 'globals';
 import rootEslintConfig from './root.eslint.config.mjs';
 
+export const nodeLanguageOptionsAndRules = {
+  languageOptions: {
+    globals: {
+      ...globals.node,
+
+      // Deno
+      // TODO: define only where needed https://github.com/phetsims/chipper/issues/1451
+      Deno: 'readonly'
+    }
+  },
+  rules: {
+    '@typescript-eslint/no-require-imports': 'off',
+    '@typescript-eslint/no-var-requires': 'off'
+  }
+};
+
+export const nodeNoFloatingPromises = {
+
+  // For entry points like scripts and "grunt" tasks, we often end with a floating promise which is not a problem
+  files: [
+    '**/js/grunt/tasks/**/*',
+    '**/js/scripts/**/*'
+  ],
+  rules: {
+    '@typescript-eslint/no-floating-promises': 'off'
+  }
+};
+
 /**
  * The node-specific eslint config applied only to "server-side" files that aren't run in sims.
  */
 export default [
   ...rootEslintConfig,
-  {
-    languageOptions: {
-      globals: {
-        ...globals.node,
-
-        // Deno
-        // TODO: define only where needed https://github.com/phetsims/chipper/issues/1451
-        Deno: 'readonly'
-      }
-    }
-  } ];
+  nodeLanguageOptionsAndRules,
+  nodeNoFloatingPromises
+];