remove many TODOs and general cleanup, phetsims/chipper#1451

Signed-off-by: Michael Kauzmann <[email protected]>
phetsims · Oct 22, 2024 · 47c4953 · 47c4953
1 parent d02a5c6
commit 47c4953
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/eslint/root.eslint.config.mjs b/eslint/root.eslint.config.mjs
@@ -177,11 +177,10 @@ export default [
     languageOptions: {
 
       // TODO: upgrade version: Maybe 2022? https://github.com/phetsims/chipper/issues/1451
-      ecmaVersion: 8,
+      ecmaVersion: 2022,
       sourceType: 'module',
 
       // Without a parser, .js files are linted without es6 transpilation. Use the same parser that we use for TypeScript.
-      // TODO: always use this parser? https://github.com/phetsims/chipper/issues/1451
       parser: typescriptEslintParser
 
       // TODO: probably don't want node and browser here in the root, see https://github.com/phetsims/chipper/issues/1451
@@ -1154,7 +1153,6 @@ export default [
       'bad-sim-text': 'off'
     },
     // Lint javascript in HTML files too
-    // TODO: Restore html plugin, see https://github.com/phetsims/chipper/issues/1451
     plugins: {
       html: html
     }
@@ -1178,11 +1176,8 @@ export default [
       '**/*.tsx'
     ],
     languageOptions: {
-
       parserOptions: {
-
-        // Look up type information from the closest tsconfig.json
-        projectService: true
+        projectService: true // Look up type information from the closest tsconfig.json
       }
     },
     plugins: {

diff --git a/eslint/rules/default-import-match-filename.js b/eslint/rules/default-import-match-filename.js
@@ -19,7 +19,6 @@ function removeExtension( filename ) {
   return path.basename( filename, path.extname( filename ) );
 }
 
-// TODO: Shouldn't this fix remove the need for some eslint-disable-lines? See https://github.com/phetsims/chipper/issues/1451
 function matchesCamelCase( localName, filenameWithoutExtension ) {
   return localName === _.camelCase( filenameWithoutExtension );
 }