-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac VO may not read new volt/resistance value #141
Comments
It sounds like the aria-valuetext not coming through. @KatieWoe when this happened did you hear other alert information like "As letter V grows, letter I grows. Current now 10.0 milliamps."? |
@jessegreenberg yes I did |
OK, thanks. |
@jessegreenberg, FYI, I have noticed a little bit of I suspect what I noticed is similar to what @KatieWoe noticed. |
Interesting, thanks @terracoda. Has this always been an issue for VoiceOver or is this relatively new? |
I just tried to reproduce this on latest macOS with MacinCloud, but audio and VO are still not working on that service. |
@zepumph just showed me that not hearing aria-valuetext is possible on NVDA too if slider movement is timed just right, so I will investigate there. |
I just tried for several minutes to see this with NVDA but couldn't on my Windows 10 desktop in Chrome or Firefox. I am wondering if this is performance related. Ill try on my slower laptop. |
I just tried on my Windows 10 laptop and heard all aria-valuetext in between alerts. When @zepumph had showed me over screen share we saw a number of alerts come through without hearing any aria-valuetext. But I couldn't get that to happen on my side on two different Windows machines. |
I am able to produce this pretty easily with macOS 10.10.5 by doing this:
This is pretty similar to what @KatieWoe reported so I am going to try to debug this even though I only have macOS 10.10 |
So I am able to reproduce this bug with macOS 10.10.5 VO pretty consistently with https://jsfiddle.net/gj8zmhfy/3/. Basically, if the slider moves while the alert is being read, all subsequent aria-valuetext is ignored. @KatieWoe can you please try to do this on a more recent macOS and see if the problem happens there? Do you stop hearing "Value: 49" and so on? |
Here is also a version where we separate aria-valuetext and alerts by 1000 ms, and I the issue happens there too on macOS 10.10.5 https://jsfiddle.net/gj8zmhfy/5/ |
Tested first link so far. On 10.14.4. When interrupting "This is a new alert: #" I always heard the new value. It did cause the "This is a new alert" to read old alerts and repeat several of them. |
Thanks @KatieWoe. On my version the lack of "Value: X" was easy to reproduce so it must be due to my very old OS. Ill keep working on it. |
I tried to set up a macOS 10.14 system locally to debug but ran into problems with audio on the guest OS. I tried to debug just by watching the VoiceOver text display, but Safari kept crashing because audio was unsupported in the virtual machine. Then I tried to test in Chrome, but the system was too slow with VoiceOver to get any useful info. Unfortunately, I don't think I will be able to debug this any further without access to a device with macOS 10.14. Based on the fact that we cannot reproduce this in #141 (comment) I am guessing this is either performance related or a screen reader quirk. Further investigation might include determining
@emily-phet @terracoda do you believe that this issue should block publication of ohms-law? Either way, is it worthwhile to spend more time on this issue? I am unclear how disruptive this issue is to user experience. I asked @KatieWoe how frequently this happened and she replied:
|
@jessegreenberg Let's proceed with publishing the sim. In the long term - Not sure atm whether this is worth investigating further. Let's let @terracoda weigh in before officially deciding. Seems like it could be a general quirk with VO and the current aria-valuetext/alerts setup, so my guess is we'll probably want to at least check through your bullet list above of next steps. |
@jessegreenberg and @emily-phet, I agree we should proceed with publishing the sim. I haven't played with Ohm's Law in a long time, but the infrequent skips in And to answer an earlier question, is this a new issue, in #141 (comment), honestly, I am not sure. I know VO has had trouble with aria-live alerts in the past, but I am not sure about |
Sounds great, thanks @terracoda and @emily-phet. I created the above issue in sun because this will impact all sims. Since we will continue with publication without this issue resolved, I will close this one. I will also added this to https://docs.google.com/document/d/12kTs-g-iKEIH1dyG7Q41_W_oNL4gUKbkW-IQgZjMUBw/edit since it is unclear whether this can be resolved or is a VoiceOver bug. |
For phetsims/qa#313
Mac 10.14.4 Safari 12.1
I noticed one instance where Mac VO didn't read the new volt/resistance value when using keyboard nav. Once it came back though, it didn't seem to do it again. It happened one right after another for awhile, but when I managed to get it to come back, it stayed back. Not sure what caused it since I didn't reproduce it. Seemed like it might have been connected to interrupting an alert
The text was updated successfully, but these errors were encountered: