secondLocaleStringsProperty has type any

[pixelzoom]

In NumberSuiteCommonPreferences.ts, this use of IntentionalAny seems to be causing problems with addressing phetsims/number-play#197:

  // helper Properties derived from preference Properties
  public readonly secondLocaleStringsProperty: TReadOnlyProperty<IntentionalAny>;

I'll investigate why this is IntentionalAny, and whether we can make it type-specific.

[pixelzoom]

secondLocaleStringsProperty is an object literal that contains the complete set of strings for the second locale.

[pixelzoom]

This is a nasty little problem, and resolving it means addressing phetsims/number-play#199 and the problem of string Properties for the secondary locale. Since that issues is deferred, I decided to (mostly) punt on this issue for now, and label it as deferred.

I did rename a couple of things for clarity, see above commits. And I replace the multiple occurrences of IntentionalAny with a type that is defined in NumberSuiteCommonPreferences.ts:

//TODO https://github.com/phetsims/number-suite-common/issues/18 replace any
// eslint-disable-next-line @typescript-eslint/no-explicit-any
export type SecondLocaleStrings = any;