New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create color file #77

Closed

Luisav1 opened this issue Dec 7, 2021 · 1 comment

Assignees

Labels

dev:code-review

Contributor

Luisav1 commented Dec 7, 2021

From my self code review in #75

All sims should use a color file named MyRepoColors.js or, if using abbreviations, MRColors.js, and
use ProfileColorProperty where appropriate, even if they have a single (default) profile (to support color editing
and PhET-iO Studio). The ColorProfile pattern was converted to *Colors.js files in
phetsims/scenery-phet#515. Please see
GasPropertiesColors.js
for a good example.

The text was updated successfully, but these errors were encountered:

Luisav1 added the dev:code-review label

Luisav1 assigned chrisklus

chrisklus added a commit that referenced this issue


          Use ColorProperties instead of constants, see #77

50a163c

Contributor Author

Luisav1 commented Dec 13, 2021

Color file created. Closing this issue.

Luisav1 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment