Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MissingVoiceWarningButton missing #17

Closed
chrisklus opened this issue Jan 31, 2023 · 4 comments
Closed

MissingVoiceWarningButton missing #17

chrisklus opened this issue Jan 31, 2023 · 4 comments
Assignees
@chrisklus
Labels
status:ready-for-review type:bug Something isn't working

Comments

@chrisklus
Copy link
Contributor

MissingVoiceWarningButton is included in Number Play but missing in Number Compare. I should factor out a type that puts these into one control and then use that in NP and NC.
@chrisklus chrisklus added the type:bug Something isn't working label Jan 31, 2023
@chrisklus chrisklus self-assigned this Jan 31, 2023
@pixelzoom
Copy link
Contributor

I'll take this one. Will factor out a control that includes SpeechSynthesisButton and MissingVoiceWarningButton.

@pixelzoom pixelzoom assigned pixelzoom and unassigned chrisklus Feb 1, 2023
pixelzoom added a commit to phetsims/number-suite-common that referenced this issue Feb 1, 2023
@pixelzoom
factor out SpeechSynthesisControl, using in both sims, phetsims/numbe…
4227ce7 
…r-compare#17
pixelzoom added a commit that referenced this issue Feb 1, 2023
@pixelzoom
factor out SpeechSynthesisControl, using in both sims, #17
dea3c71
pixelzoom added a commit to phetsims/number-play that referenced this issue Feb 1, 2023
@pixelzoom
factor out SpeechSynthesisControl, using in both sims, phetsims/numbe…
606c2dc 
…r-compare#17
pixelzoom added a commit to phetsims/number-suite-common that referenced this issue Feb 1, 2023
@pixelzoom
doc phetsims/number-compare#17
85048a0
@pixelzoom
Copy link
Contributor

In the above commit, I factored out SpeechSynthesisControl, and used it in both NumberPlayScreenView (Ten and Twenty screens) and CompareScreenView. Note the layout problem in the Compare screen, reported in #18 -- it was present before making this change.

@chrisklus please review, close if OK.

@pixelzoom pixelzoom assigned chrisklus and unassigned pixelzoom and chrisklus Feb 1, 2023
pixelzoom added a commit to phetsims/beers-law-lab that referenced this issue Feb 1, 2023
@pixelzoom
use phetioVisiblePropertyInstrumented: false, phetsims/number-compare#17
fe5cc1f
@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 1, 2023 •
edited
Loading

Please ignore commits shown immediately above, phetsims/beers-law-lab@fe5cc1f and https://github.com/phetsims/phet-io-sim-specific/commit/7502a1ebe68577242d2c014bc5d93d75c68513e4. They were incorrectly associated with this issue.

chrisklus added a commit to phetsims/number-suite-common that referenced this issue Feb 1, 2023
@chrisklus
Simplify SpeechSynthesisButton constructor signature typing, see phet…
e7c9011 
…sims/number-compare#17
@chrisklus
Copy link
Contributor Author

Thanks @pixelzoom! Looks great. I simplified parameter typing in SpeechSynthesisButton above based on your commit in phetsims/number-suite-common@4227ce7. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisklus chrisklus

Labels
status:ready-for-review type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @chrisklus