Leading and trailing separators still visible

[samreid]

According to the scenery documentation https://phetsims.github.io/scenery/doc/layout#separators leading and trailing separators should be invisible. However, in My Solar System if I hide the checkbox before the first separator like this:

Subject: [PATCH] Standardize author annotations
---
Index: js/common/view/MySolarSystemControls.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/common/view/MySolarSystemControls.ts b/js/common/view/MySolarSystemControls.ts
--- a/js/common/view/MySolarSystemControls.ts	(revision 03cf57190db382b349faa663de190cb23b3bb8d6)
+++ b/js/common/view/MySolarSystemControls.ts	(date 1679411791931)
@@ -33,7 +33,7 @@
 
     super( {
       children: [
-        ...createOrbitalInformationCheckboxes( model, providedOptions.tandem ),
+        // ...createOrbitalInformationCheckboxes( model, providedOptions.tandem ),
         new HSeparator( SolarSystemCommonConstants.HSEPARATOR_OPTIONS ),
         ...createArrowsVisibilityCheckboxes( model, providedOptions.tandem ),
         new HBox( {

The separator is still visible (above the speed checkbox):

[jonathanolson]

The layoutOptions in SolarSystemCommonConstants.HSEPARATOR_OPTIONS is overriding the normal separator options (where it specifies that it is a separator).

Thinking about the best way to handle this.

[jonathanolson]

Fix pushed above. However it's a bit inconvenient that the layout options aren't combinable. I wonder if it should switch to a model where it mutates by default (instead of... setting it as an entire object). Thoughts?

[samreid]

In the commit, @AgustinVallejo exported the default separator layout options so it is possible for clients to extends rather than replace them. Closing.