-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an "array strategy" for first 3 screens #334
Comments
tagging phetsims/qa#1121 |
This is ready for @amanda-phet to review. |
It looks like @amanda-phet accidentally added feedback for this issue elsewhere. Here is what she said.
It seems to be working well on the Distribute and Faire Share screens! @amanda-phet let me know if I put the feedback in the wrong issue. |
I met with @amanda-phet and we found a way to reproduce:
|
Due to a small oversight I was not iterating over all cups, only active cups which was causing the behavior. That should be fixed. @amanda-phet can you take a look now and make sure behavior is as expected? I can then mark for cherry-pick. |
It's working! Thanks! |
Great! Ready for cherry-pick. |
The array strategies are working nicely! Closing. |
Nancy noticed that when was trying to set the cup or plate values before they were visible, weird things happened (the default values overwrote the values she set, and some bars/apples became visible when they shouldn’t have).
@marlitas @Nancy-Salpepi and I discussed this and would like to move ahead with this idea, which @arouinfar approved of:
Create an "array strategy” (similar to kickDistributionStrategy) as a new element in the tree that lets the user set all cup/plate values, even if they aren’t visible. This would allow someone to pre-set all values for any screen even before they are visible. We would also change tableSnackNumberProperty to be read-only.
The text was updated successfully, but these errors were encountered: