Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong/No sound heard when closing the info dialog #330

Closed
Tracked by #1134
Nancy-Salpepi opened this issue Jul 31, 2024 · 4 comments
Closed
Tracked by #1134

Wrong/No sound heard when closing the info dialog #330

Nancy-Salpepi opened this issue Jul 31, 2024 · 4 comments
Labels

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
14.5

Browser
Safari 17.5

Problem description
For phetsims/qa#1121, when closing the info dialog on screens 2-4 by pressing the X, the 'open' sound is heard. Also, no sound is heard when pressing esc to exit the dialog. If I press the Info button to close instead of the 'X', I do hear the 'close' sound.

Steps to reproduce

  1. Go to screens 2,3 or 4 and press the Info button
  2. Press the X to close the dialog
  3. Press the Info button again
  4. Press esc

Visuals

closeDialogSound.mp4
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Mean: Share and Balance‬ URL: https://phet-dev.colorado.edu/html/mean-share-and-balance/1.1.0-rc.1/phet/mean-share-and-balance_all_phet.html Version: 1.1.0-rc.1 2024-07-23 23:49:04 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Safari/605.1.15 Language: en-US Window: 1405x714 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@Nancy-Salpepi Nancy-Salpepi added the type:bug Something isn't working label Jul 31, 2024
@Nancy-Salpepi
Copy link
Author

I also hear the open sound when pressing the 'X' to close the dialog using alt input.

@marlitas
Copy link
Contributor

marlitas commented Aug 1, 2024

It looks like this cam from a simple typo in phetsims/tambo#195. The commit to cherry pick is there.

That commit does not resolve the sound not playing on esc.

@marlitas
Copy link
Contributor

marlitas commented Aug 5, 2024

escape key now triggers the close button sound as needed. Ready for cherry pick.

@Nancy-Salpepi
Copy link
Author

Sounds good in rc.2.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants