-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong/No sound heard when closing the info dialog #330
Labels
Comments
I also hear the open sound when pressing the 'X' to close the dialog using alt input. |
It looks like this cam from a simple typo in phetsims/tambo#195. The commit to cherry pick is there. That commit does not resolve the sound not playing on |
marlitas
added a commit
that referenced
this issue
Aug 5, 2024
escape key now triggers the close button sound as needed. Ready for cherry pick. |
21 tasks
Sounds good in rc.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test device
MacBook Air M1 chip
Operating System
14.5
Browser
Safari 17.5
Problem description
For phetsims/qa#1121, when closing the info dialog on screens 2-4 by pressing the X, the 'open' sound is heard. Also, no sound is heard when pressing
esc
to exit the dialog. If I press the Info button to close instead of the 'X', I do hear the 'close' sound.Steps to reproduce
esc
Visuals
closeDialogSound.mp4
The text was updated successfully, but these errors were encountered: