-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VO says "text" after temperature unit #178
Comments
I took a look at the parallel DOM and don't see anything amiss. It is indeed "text", so maybe VoiceOver is reporting that role of the content. @Nancy-Salpepi can you please see if this happens in the first combobox example here? https://dequelabs.github.io/combobo/demo/ |
@jessegreenberg in the first combobox it said "clickable" after each. I then tried the second combo box and VO didn't say anything extra after each option. |
Got it, OK thanks. Some differences between our listbox and deque's:
I don't know why that would make "text" get read out after our list items. @terracoda do you have any recommendations about next steps for this issue? Should we change our markup or aria? Or should we leave it as is? |
noting that mobile VO doesn't say "text" as I move through the temperature units |
I am pretty sure when we created the HTML for PhET’s combobox, the role combobox was not well supported. Things may have changed. If role combobox is well supported now, we may need to update our design pattern. |
Just an FYI, that deque example sounds good with iOS VoiceOver. |
@jessegreenberg, I am marking as won't fix, though, I am open to code options that would remove "text" from our combobox options. At this point in time, I think our pattern offers a better experience in our context. |
And just noting that our pattern is based one of Bryan Gravante's patterns. Though I am no longer certain which one :-) |
Great, thanks for the reminders and resources @terracoda! I am going to go ahead and close this, but I am going to add it to the list of screen reader quirks that we expect on VoiceOver + macOS Safari. |
Test device
MacBook Air (m1 chip)
Operating System
macOS 12.4
Browser
Safari
Problem description
For phetsims/qa#811
When moving through the temperature units, VO adds the word "text" after each unit.
Steps to reproduce
Visuals
tempvalues.mov
The text was updated successfully, but these errors were encountered: