Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard help dialog is missing #169

Closed
Tracked by #819
Nancy-Salpepi opened this issue Jun 13, 2022 · 6 comments
Closed
Tracked by #819

keyboard help dialog is missing #169

Nancy-Salpepi opened this issue Jun 13, 2022 · 6 comments

Comments

@Nancy-Salpepi
Copy link

For phetsims/qa#811, since we are testing interactive description and keyboard nav in 1.1.0-dev.9, shouldn't there be a keyboard help dialog?

@jbphet
Copy link
Contributor

jbphet commented Jun 15, 2022

I've added the default keyboard dialog, but I'm now wondering if there needs to be a custom version created, such as we did in phetsims/faradays-law#176. I'll ask about this in the next design meeting.

@jbphet
Copy link
Contributor

jbphet commented Jun 15, 2022

Discussed in today's design meeting, things to note:

  • The "Basic Actions" should be there (we think it's on by default)
  • Add in the slider control section (we think this is an option to the dialog)
  • For now, we will use the same dialog for all screens
  • We may need to add custom information for the interaction with the flux meter, but this isn't necessary for the upcoming interviews on the "Waves" screen

@jbphet
Copy link
Contributor

jbphet commented Jun 15, 2022

I've added a specific issue about adding specific keyboard help info for the flux meter, which is the only thing we could think of in the design meeting that might require custom verbiage about how to use it. See #180.

@jbphet
Copy link
Contributor

jbphet commented Jun 15, 2022

I will have QA verify this in the next dev release.

@jbphet
Copy link
Contributor

jbphet commented Jul 8, 2022

Note to QA: Please close after verifying.

@Nancy-Salpepi
Copy link
Author

Keyboard dialog is present in version 1.1.0-dev.10 with slider controls and basic actions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants