improve keyboard help dialog wording, see #180

phetsims · Dec 22, 2022 · 7c84332 · 7c84332
1 parent 870cbc9
commit 7c84332
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/greenhouse-effect-strings_en.json b/greenhouse-effect-strings_en.json
@@ -53,6 +53,9 @@
   "valuePercentPattern": {
     "value": "{{value}}%"
   },
+  "sliderAndFluxMeterControls": {
+    "value": "Slider and Flux Meter Controls"
+  },
   "concentrationPanel.greenhouseGasConcentration": {
     "value": "Greenhouse Gas Concentration"
   },

diff --git a/js/GreenhouseEffectStrings.ts b/js/GreenhouseEffectStrings.ts
@@ -33,6 +33,7 @@ type StringsType = {
   'infraredStringProperty': LinkableProperty<string>;
   'infraredAbsorbanceStringProperty': LinkableProperty<string>;
   'valuePercentPatternStringProperty': LinkableProperty<string>;
+  'sliderAndFluxMeterControlsStringProperty': LinkableProperty<string>;
   'concentrationPanel': {
     'greenhouseGasConcentrationStringProperty': LinkableProperty<string>;
     'lotsStringProperty': LinkableProperty<string>;

diff --git a/js/common/view/GreenhouseEffectKeyboardHelpContent.ts b/js/common/view/GreenhouseEffectKeyboardHelpContent.ts
@@ -6,15 +6,18 @@
  */
 
 import BasicActionsKeyboardHelpSection from '../../../../scenery-phet/js/keyboard/help/BasicActionsKeyboardHelpSection.js';
+import KeyboardHelpSection from '../../../../scenery-phet/js/keyboard/help/KeyboardHelpSection.js';
 import SliderControlsKeyboardHelpSection from '../../../../scenery-phet/js/keyboard/help/SliderControlsKeyboardHelpSection.js';
-import TwoColumnKeyboardHelpContent from '../../../../scenery-phet/js/keyboard/help/TwoColumnKeyboardHelpContent.js';
 import TimingControlsKeyboardHelpSection from '../../../../scenery-phet/js/keyboard/help/TimingControlsKeyboardHelpSection.js';
+import TwoColumnKeyboardHelpContent from '../../../../scenery-phet/js/keyboard/help/TwoColumnKeyboardHelpContent.js';
 import greenhouseEffect from '../../greenhouseEffect.js';
-import KeyboardHelpSection from '../../../../scenery-phet/js/keyboard/help/KeyboardHelpSection.js';
+import GreenhouseEffectStrings from '../../GreenhouseEffectStrings.js';
 
 class GreenhouseEffectKeyboardHelpContent extends TwoColumnKeyboardHelpContent {
   public constructor() {
-    const sliderHelpSection = new SliderControlsKeyboardHelpSection();
+    const sliderHelpSection = new SliderControlsKeyboardHelpSection( {
+      headingStringProperty: GreenhouseEffectStrings.sliderAndFluxMeterControlsStringProperty
+    } );
     const basicActionsHelpSection = new BasicActionsKeyboardHelpSection();
 
     const timingControlsHelpSection = new TimingControlsKeyboardHelpSection();