Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object position changes if sim is launched while zoomed out #469

Closed
KatieWoe opened this issue May 12, 2023 · 4 comments
Closed

Object position changes if sim is launched while zoomed out #469

KatieWoe opened this issue May 12, 2023 · 4 comments
Assignees
@KatieWoe
Labels
dev:phet-io status:ready-for-review type:bug Something isn't working

Comments

@KatieWoe
Copy link
Contributor

Device
Samsung
OS
Win 11
Browser
Chrome
Problem Description
For phetsims/qa#938 and phetsims/qa#939.
If you are zoomed out on a scene and the object is further from the lens/mirror than it would be when fully zoomed in then the object will be moved to that closer distance when launched, even if there is room further from the lens/mirror.
Steps

  1. Zoom the scene out
  2. Move the object further from the lens/mirror. Not necessarily to the edge
  3. Launch the sim

Visuals
start
end
@KatieWoe KatieWoe added the type:bug Something isn't working label May 12, 2023
@pixelzoom
Copy link
Contributor

pixelzoom commented May 15, 2023 •
edited
Loading

Reproduced in master. This is a problem with framed objects and lights, but not with arrows.

The cause of this may be the same as the problem with tools in #467.

@pixelzoom pixelzoom changed the title Object changes position if sim is launched while zoomed out Object position changes if sim is launched while zoomed out May 15, 2023
@KatieWoe KatieWoe mentioned this issue May 16, 2023
Closed
@pixelzoom pixelzoom assigned KatieWoe and unassigned pixelzoom May 17, 2023
pixelzoom added a commit that referenced this issue May 17, 2023
@pixelzoom
do not reposition object when restoring dragBounds, #469
0e6ba52
@pixelzoom
Copy link
Contributor

Addressed in the commit above. @KatieWoe please verify in master, close if OK. Be sure to test all object types: at least 1 framed object (e.g. "Pencil"), Arrow, and Light.

pixelzoom added a commit that referenced this issue May 17, 2023
@pixelzoom
Do not disturb positionProperty when restoring dragBoundsProperty, #469
7bc4862
@KatieWoe
Copy link
Contributor Author

This looks good with all three object types on master :)

@pixelzoom
Copy link
Contributor

Thanks @KatieWoe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KatieWoe KatieWoe

Labels
dev:phet-io status:ready-for-review type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @KatieWoe