Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hear hints to use keyboard in drag/grab interactions on first grab when using mobile VO #307

Closed
terracoda opened this issue Jul 28, 2022 · 3 comments

Comments

@terracoda
Copy link
Contributor

While investigating #294, I found that on the first grab of either book interaction, I got a rubbing hint that included pressing hot keys (A & D for the regular book and WAS&D for the zoomed-in book).

I think there should be an option (already implemented in common-code) to use a mobile-specific hint once a grab/drag interaction is activated on mobile. Or possibly there is no mobile specific hint needed, since the user just needs to keep their finger down and rub after a successful double tap & hold. Regardless, I should never hear anything about pressing keyboard keys when using mobile. The keyboard instructions are platform specific.

This issue happened twice for me during testing.
I think it only happens on the first successful grab.

@terracoda terracoda changed the title Hear hints to use keyboard in drag/grb interaction on first grab when using mobile VO Hear hints to use keyboard in drag/grab interactions on first grab when using mobile VO Jul 28, 2022
@zepumph
Copy link
Member

zepumph commented Aug 26, 2022

Looks like we just never created touch/gesture hints for this case. You are right they are only on the first grab. "Subsequent" grabs after successfully making friction won't have this.

I took a first pass at them, please review and let me know what actual strings you want here:

"initialKeyboardGrabbedNotTouching": {
"value": "Grabbed. Lightly on Physics book. Move book with W, A, S, or D key. Space to release."
},
"initialTouchGrabbedNotTouching": {
"value": "Grabbed. Lightly on Physics book. Drag finger to move book. Lift finger to release."
},
"initialKeyboardGrabbedTouching": {
"value": "Grabbed. Rub fast or slow with A or D keys. Space to release."
},
"initialTouchGrabbedTouching": {
"value": "Grabbed. Rub fast or slow dragging left or right. Lift to release."
},

@zepumph
Copy link
Member

zepumph commented Aug 31, 2022

@terracoda and I discussed. We feel good about the above description. Closing.

@zepumph zepumph closed this as completed Aug 31, 2022
@terracoda
Copy link
Contributor Author

The hints sound great on mobile VO! Awesome work! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants