Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficult to grab zoomed in book when located at top of window #281

Closed
Nancy-Salpepi opened this issue Mar 31, 2022 · 3 comments
Closed

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
12.3

Browser
Safari/Chrome

Problem description
For phetsims/qa#791
After atoms have been rubbed off, it can be difficult to grab the zoomed in book when it is at the top of the window. When interactive highlights are on, I can see that grabbing the space will result in me grabbing the book. When they are off, it is my instinct to grab the atoms and I can't. In the published version, I am able to grab the atoms.

Steps to reproduce

  1. Move zoomed in book to rub off all the atoms.
  2. Move zoomed in book to top of window and release.
  3. Try to grab zoomed in book.

Visuals
Dev version:

hardtograbbook.mp4

Published version:
grabinpublished.mp4
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Friction‬ URL: https://phet-dev.colorado.edu/html/friction/1.6.0-dev.24/phet/friction_all_phet.html Version: 1.6.0-dev.24 2022-03-30 15:06:07 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.4844.84 Safari/537.36 Language: en-US Window: 1431x690 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@KatieWoe
Copy link
Contributor

KatieWoe commented Mar 31, 2022

I noticed that, in the dev test, the bubbles in the row attached to the book are not grabbable. This is not the case for the published sim, which seems to worsen the problem now compared to previous versions.

Edit: I even had this cause a bit of difficulty when no orbs were lost when that was the area of the book I just so happened to try to grab.

@zepumph
Copy link
Member

zepumph commented Jul 8, 2022

Very helpful bug report. The regression was in the little bumps on the background blue. Should be fixed, please confirm and feel free to close.

@Nancy-Salpepi
Copy link
Author

Looks good! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants