Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move phet-io-wrapper-classroom-activity to live in phet-io-sim-specific #300

Open
samreid opened this issue Apr 6, 2023 · 3 comments
Open

Comments

@samreid
Copy link
Member

samreid commented Apr 6, 2023

As described in https://github.com/phetsims/phet-io-sim-specific/issues/1#issuecomment-1215128095, we should Move phet-io-wrapper-classroom-activity to live in phet-io-sim-specific. Ideally scouring the maintenance releases for references to the phet-io-wrapper-classroom-activity so it can be removed as a dependency.

@zepumph
Copy link
Member

zepumph commented Apr 22, 2024

For now I recommend removing this wrapper from package.json. It doesn't need any more work than that to release us from the maintenance burden that a new release will incur if we keep it as a dependency. @samreid, does that seem like a reasonable path forward until we next need to care about the classroom activity wrapper?

Subject: [PATCH] fhdsajfkdsl
---
Index: package.json
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/package.json b/package.json
--- a/package.json	(revision 28e73be871e0630a11fe20da23c0e5a0dd2bdf8d)
+++ b/package.json	(date 1713823944540)
@@ -30,10 +30,7 @@
     },
     "simulation": true,
     "phet-io": {
-      "validation": false,
-      "wrappers": [
-        "phet-io-wrapper-classroom-activity"
-      ]
+      "validation": false
     },
     "supportsOutputJS": true,
     "published": true,

@samreid
Copy link
Member Author

samreid commented Apr 24, 2024

Yes, sounds good, thanks!

@Luisav1
Copy link
Contributor

Luisav1 commented Apr 24, 2024

The classroom activity wrapper has been removed from package.json, resolving the dependency issue. Thus, this no longer blocks publication. I'll leave this issue open and deferred until there's a need to address the classroom activity wrapper again. Thanks for the collaboration!

@Luisav1 Luisav1 removed their assignment Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants