Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description prototype is being run on every sim run #197

Closed
zepumph opened this issue May 9, 2024 · 1 comment
Closed

Description prototype is being run on every sim run #197

zepumph opened this issue May 9, 2024 · 1 comment
Labels
status:blocks-sim-publication

Comments

@zepumph
Copy link
Member

zepumph commented May 9, 2024

We should not republish this sim without figuring out how to handle this. Work has been done over in phetsims/joist#941.
samreid added a commit to phetsims/density-buoyancy-common that referenced this issue May 17, 2024
@samreid
Guard the description prototype with a flag, see phetsims/joist#941 and
2bfc542 
phetsims/density#197
samreid added a commit that referenced this issue May 17, 2024
@samreid
Guard the description prototype with a flag, see phetsims/joist#941 and
cabdf85 
#197
@samreid
Copy link
Member

samreid commented May 17, 2024

@zepumph and I fixed this, closing. Heads up to @jonathanolson so he is aware a flag ?descriptionPrototype is needed now.

@samreid samreid closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:blocks-sim-publication
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph