no-constant-condition allows while (true) by default

[samreid]

Discovered in #1451, https://eslint.org/docs/latest/rules/no-constant-condition says:

This is a string option having following values:

"all" - Disallow constant expressions in all loops.
"allExceptWhileTrue" (default) - Disallow constant expressions in all loops except while loops with expression true.
"none" - Allow constant expressions in loops.

This is a recent change that removed the need to put disable directives on our while(true) loops. I think it is OK to go with the new default but I opened this issue to check with @zepumph

[samreid]

Committed locally but not pushed yet

[samreid]

We agreed this is good, closing.