Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webstorm: Add TypeScript -> "sort imports by module" to code style #1462

Closed
zepumph opened this issue Sep 16, 2024 · 8 comments
Closed

Webstorm: Add TypeScript -> "sort imports by module" to code style #1462

zepumph opened this issue Sep 16, 2024 · 8 comments
Assignees
@zepumph

Comments

@zepumph
Copy link
Member

zepumph commented Sep 16, 2024

From discussion today #1461. If we add this to the code style and optimize all imports, then things will be much cleaner.
@zepumph zepumph self-assigned this Sep 16, 2024
@samreid samreid changed the title Webstory Add TypeScript -> "sort imports by module" to code style Webstorm: Add TypeScript -> "sort imports by module" to code style Sep 17, 2024
zepumph added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
b7fa931 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/circuit-construction-kit-common that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
805a84a 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/generator that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
3e3396e 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/arithmetic that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
5410371 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/circuit-construction-kit-ac that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
383a432 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/brand that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
e8e1022 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/area-model-algebra that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
35c753b 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/aqua that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
cb0f9f9 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/build-a-nucleus that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
73d923f 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/function-builder-basics that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
0b1f9e6 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/scenery-phet that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
35066b4 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/gas-properties that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
31687ea 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/area-model-multiplication that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
d146b44 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/beers-law-lab that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
1a518b0 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/energy-skate-park that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
cca4971 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/phet-lib that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
4bd3272 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/graphing-lines that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
cda52c0 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/shred that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
f65d22b 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/magnets-and-electromagnets that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
8e97a4b 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/phet-core that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
a11d6a5 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/quadrilateral that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
327d93f 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/number-play that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
d9e1fa5 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/kite that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
ac16ee2 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/nitroglycerin that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
81cc28b 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/number-pairs that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
372ac7f 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/axon that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
e0c3074 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/tappi that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
91c4c2c 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/wilder that referenced this issue Sep 23, 2024
@zepumph
sort imports by module name in TypeScript too, phetsims/chipper#1462
c3d152d 
Signed-off-by: Michael Kauzmann <[email protected]>
samreid added a commit to phetsims/ratio-and-proportion that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
d99c329
samreid added a commit to phetsims/mean-share-and-balance that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
5a71a34
samreid added a commit to phetsims/ph-scale that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
43557d1
samreid added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
3cf4443
samreid added a commit to phetsims/fourier-making-waves that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
12cb28f
samreid added a commit to phetsims/gravity-force-lab that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
7f739ab
samreid added a commit to phetsims/tandem that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
24e6abe
samreid added a commit to phetsims/build-a-nucleus that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
408a27d
samreid added a commit to phetsims/gravity-and-orbits that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
3fe0752
samreid added a commit to phetsims/beers-law-lab that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
ba81e93
samreid added a commit to phetsims/axon that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
366806a
samreid added a commit to phetsims/gas-properties that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
dc42a59
samreid added a commit to phetsims/geometric-optics that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
1925f0b
samreid added a commit to phetsims/gases-intro that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
8f90924
samreid added a commit to phetsims/quadrilateral that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
a859a81
samreid added a commit to phetsims/phet-core that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
0d86cb1
samreid added a commit to phetsims/joist that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
adc53a0
samreid added a commit to phetsims/faradays-electromagnetic-lab that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
00474ea
samreid added a commit to phetsims/phetcommon that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
74bcfa5
samreid added a commit to phetsims/example-sim that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
6bc575a
samreid added a commit to phetsims/bending-light that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
e3e0eca
samreid added a commit to phetsims/models-of-the-hydrogen-atom that referenced this issue Nov 27, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
5bfa6a8
@samreid
Copy link
Member

samreid commented Nov 27, 2024

I swamped the issue with commits, please be aware there are comments that got hidden above.

zepumph added a commit to phetsims/alpenglow that referenced this issue Nov 27, 2024
@zepumph
lint problems, phetsims/chipper#1462
54e6862
@zepumph zepumph assigned zepumph and unassigned samreid Nov 27, 2024
@zepumph
Copy link
Member Author

zepumph commented Nov 27, 2024

I'm not sure why my webstorm was not able to optimize all files, but @samreid was able to run it once from the main checkout dir. I checked on some of the repos and everything looks great. Closing

@zepumph zepumph closed this as completed Nov 27, 2024
jessegreenberg pushed a commit to phetsims/perennial that referenced this issue Dec 10, 2024
@samreid @jessegreenberg
Sort imports and run grunt modulify, see phetsims/chipper#1462
47cd07b
marlitas pushed a commit to phetsims/number-suite-common that referenced this issue Dec 12, 2024
@samreid
Sort imports and run grunt modulify, see phetsims/chipper#1462
ff504ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph