Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--noTSC isn't respected everywhere #1460

Closed
samreid opened this issue Sep 12, 2024 · 2 comments
Closed

--noTSC isn't respected everywhere #1460

samreid opened this issue Sep 12, 2024 · 2 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Sep 12, 2024

Discovered in #1459, --noTSC isn't respected everywhere. Test running a build with --noTSC and see that some tsc are skipped but some are run.

~/phet/root/buoyancy$ time grunt --brands=phet,phet-io --noTSC
Running "lint-all" task
[........................................] 100.00%

Running "report-media" task

Running "clean" task

Running "build" task
Building runnable repository (buoyancy, brands: phet, phet-io)
Building brand: phet
>> Webpack build complete: 2610ms
>> Production minification complete: 13635ms (5492392 bytes)
>> Debug minification complete: 0ms (33401768 bytes)
Building brand: phet-io
>> Webpack build complete: 2392ms
>> Production minification complete: 14446ms (5510917 bytes)
>> Debug minification complete: 15053ms (5825432 bytes)
>> tsc complete: 1717ms
>> tsc complete: 1735ms

Done.

real	1m45.253s
user	1m44.511s
sys	0m12.334s
@samreid samreid self-assigned this Sep 12, 2024
@samreid
Copy link
Member Author

samreid commented Sep 21, 2024

Here is a trace after we sped up the tsc with tsc -b:

~/phet/root/buoyancy$ time grunt --brands=phet,phet-io --noTSC
Running "default" task
[........................................] 100.00%
Linting completed successfully.
Building runnable repository (buoyancy, brands: phet, phet-io)
Building brand: phet
>> Webpack build complete: 3065ms
>> Production minification complete: 12496ms (5494520 bytes)
>> Debug minification complete: 0ms (33435299 bytes)
Building brand: phet-io
>> Webpack build complete: 2170ms
>> Production minification complete: 14017ms (5512827 bytes)
>> Debug minification complete: 0ms (33834484 bytes)
>> tsc complete: 411ms
>> tsc complete: 371ms

Done.

real	1m3.086s

Notice the 3.4s went down to 0.8s, so that is much better. We should still respect a --noTSC shutoff valve though.

@samreid
Copy link
Member Author

samreid commented Sep 23, 2024

Fixed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant