We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discovered in #1459, --noTSC isn't respected everywhere. Test running a build with --noTSC and see that some tsc are skipped but some are run.
--noTSC
~/phet/root/buoyancy$ time grunt --brands=phet,phet-io --noTSC Running "lint-all" task [........................................] 100.00% Running "report-media" task Running "clean" task Running "build" task Building runnable repository (buoyancy, brands: phet, phet-io) Building brand: phet >> Webpack build complete: 2610ms >> Production minification complete: 13635ms (5492392 bytes) >> Debug minification complete: 0ms (33401768 bytes) Building brand: phet-io >> Webpack build complete: 2392ms >> Production minification complete: 14446ms (5510917 bytes) >> Debug minification complete: 15053ms (5825432 bytes) >> tsc complete: 1717ms >> tsc complete: 1735ms Done. real 1m45.253s user 1m44.511s sys 0m12.334s
The text was updated successfully, but these errors were encountered:
Here is a trace after we sped up the tsc with tsc -b:
~/phet/root/buoyancy$ time grunt --brands=phet,phet-io --noTSC Running "default" task [........................................] 100.00% Linting completed successfully. Building runnable repository (buoyancy, brands: phet, phet-io) Building brand: phet >> Webpack build complete: 3065ms >> Production minification complete: 12496ms (5494520 bytes) >> Debug minification complete: 0ms (33435299 bytes) Building brand: phet-io >> Webpack build complete: 2170ms >> Production minification complete: 14017ms (5512827 bytes) >> Debug minification complete: 0ms (33834484 bytes) >> tsc complete: 411ms >> tsc complete: 371ms Done. real 1m3.086s
Notice the 3.4s went down to 0.8s, so that is much better. We should still respect a --noTSC shutoff valve though.
Sorry, something went wrong.
Pass noTSC to copySupplementalPhetioFiles.ts, see #1460
3e8153c
Fixed, closing.
--noTranspile
samreid
No branches or pull requests
Discovered in #1459,
--noTSC
isn't respected everywhere. Test running a build with --noTSC and see that some tsc are skipped but some are run.The text was updated successfully, but these errors were encountered: