Transpile bug upon using pull-all.js #1179
Comments
|
Tagging @samreid so he (the author), is aware of the changes. I'll check back on this in a few days to see if anything has changed. |
|
On slack @jessegreenberg said:
I think that sounds very similar to this, but I wonder if he already had pulled in this change. @jessegreenberg were you experiencing this after pulling, and restarting the transpiler since yesterday? |
|
I do not have that change on my local copy, Ill pull and see if the problem goes away. |
|
I am not sure if this is a complete test, but I checked out quadrilateral in a different location on my machine, made a test commit there, pulled that change in my normal working location, and then verified that transpile.js picked up the change. This much was working well! |
|
I would add that when I pulled all this morning, I didn't not have to restart my transpiler. I believe this is fixed. @samreid feel free to close. |
|
I ran into an issue with pull again, I don't know if it should be noted here or in a new issue. I did the following:
I saw this error in the dev tools:
Then I restarted transpiler.js and the issue went away. |
|
As I pulled all this morning, I saw the output from transpile.js indicate that it was transpiling from changes that came in during the pull. UPDATE: When I ran john-travoltage I didn't see any errors. But when I ran gravity-force-lab-basics I saw Restarting transpile.js made the problem go away. UPDATE: In the output of transpile.js during the pull I see that NumberPicker.js and Enumeration.js were Other files have a |
|
I just noticed a similar issue with |
|
This morning I had to restart my transpiler before it recompiled all the files that came in from pulling. Perhaps I need to do a bit of research in a test repo about how git pull modifies files. Maybe transpile needs to watch git operations somehow. |
|
I think this is an inherent issue with fs.watch. I found nodejs/node#5039 which led me to https://github.com/paulmillr/chokidar. Perhaps a different watch process would improve the experience. I want to poke around with this since I can so consistently reproduce the issues around git pull. I bet git stash will be an easier testing situation. Thanks @jessegreenberg! |
|
The first version of this transpiler used chokidar, but I ran into so many problems that went away when I switched to fs.watch. But maybe windows will be better off with chokidar? |
|
Oh! Good to know, hmmm, I'm not really sure then. |
|
I just noticed a similar case to this when running |
|
I still am restarting my transpiler upon git operations (mostly pull). |
I am encountering a bit of strange behavior with the Transpiler recently. It always happens after activeRepos gets reloaded. Basically the problem is that after pull all, the transpiler freezes, and doesn't detect any further changes. I believe that it is from this line, but I can't be sure. . . .
Looking at the code, it seems like there isn't a
trimcommand inchipper/js/common/Transpiler.js
Line 226 in 50745bb
Here is the output of transpiling through a pull all. Note that all the changes that occur after the restart occured while the first instance was running. It was only upon restart that the transpiler noted the changes and recomputed them.
The text was updated successfully, but these errors were encountered: