Fix task name, add TODOs, update formatting, see #1459

phetsims · Sep 12, 2024 · 8c92086 · 8c92086
1 parent 00b31de
commit 8c92086
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/js/grunt/Gruntfile.js b/js/grunt/Gruntfile.js
@@ -91,7 +91,7 @@ module.exports = function( grunt ) {
   );
 
   grunt.registerTask( 'output-js-all', 'Outputs JS for all repos',
-    execTask( '-js-all.js' )
+    execTask( 'output-js-all.js' )
   );
 
   grunt.registerTask( 'build',

diff --git a/js/grunt/tasks/clean.js b/js/grunt/tasks/clean.js
@@ -1,13 +1,13 @@
 // Copyright 2024, University of Colorado Boulder
 
-const getRepo = require( './getRepo' );
-
 /**
  * @author Sam Reid (PhET Interactive Simulations)
  */
+
+const getRepo = require( './getRepo' );
 const grunt = require( 'grunt' );
-const repo = getRepo();
 
+const repo = getRepo();
 const buildDirectory = `../${repo}/build`;
 
 // Check if the build directory exists, then delete and recreate it

diff --git a/js/grunt/tasks/getRepo.js b/js/grunt/tasks/getRepo.js
@@ -9,6 +9,7 @@ const assert = require( 'assert' );
 
 module.exports = () => {
 
+  // TODO: Unit tests to make sure options are parsed correctly from Gruntfile.js to here https://github.com/phetsims/chipper/issues/1459
   grunt.option.init( parseGruntOptions() );
 
   const packageObject = grunt.file.readJSON( 'package.json' );

diff --git a/js/grunt/tasks/parseGruntOptions.js b/js/grunt/tasks/parseGruntOptions.js
@@ -3,6 +3,9 @@
 /**
  * @author Sam Reid (PhET Interactive Simulations)
  */
+
+// TODO: Replace with nopt 4.0.1 to guarantee compatibility with grunt. See usage site: https://github.com/phetsims/chipper/issues/1459
+// /Users/samreid/phet/root/chipper/node_modules/grunt-cli/bin/grunt
 module.exports = function( grunt ) {
   function parseArgs( argv ) {
     const args = {};