-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card alternate text property #285
Comments
We would like to add an "alternate text" feature to each card. By default it would be null, which means no alternate text (and hence just show the number). This would be documented in examples #136. We will use maxWidth to make sure it stays within the card. Once done, we can review the behavior with @kathy-phet |
Before starting, we should check if the alternate text needs to be internationalized. I recommend against it, because that would make the cost exceed the value. And clients could use the wrapper to specify different placeholders in different languages. |
@kathy-phet is questioning the pedagogical advantage to hiding the card's values and replacing with something else. Some example user stories/pedagogical moves could include:
The underlying question is to create a move using the sim, and this feature doesn't seem to support these pedagogical user stories because they don't leverage the sim. Recommendation: Do not implement this feature. Don't support visibility but continue to support enable/disable in the case that the "Sort Data" checkbox is checked, the user shouldn't be able to interact with the cards because if they did, the "Sort Data" would automatically uncheck. This is not desirable because if the checkbox is disabled, the user couldn't re-check the box. In examples.md, note this possible unwanted interaction if a student moves the card while the "Sort Data" checkbox is disabled or hidden. #136 |
In the commits, we uninstrumented card visibility, and instrumented the cardNodeContainer.enabledProperty. But we still need to hide the hand when cardNodeContainer.enabledProperty is false. And make them a bit grayed out. |
We reviewed that behavior, and agreed it is good, closing. Does not need code review since it was trivial. |
From #204
The user story is:
@marlitas and I observed that each card currently has a visibleProperty that can be toggled off. This leaves a hole in the card container like so:
Therefore, we would like to know more about this user story. Is it so that clients can ask students to predict the value of a card? If so, would it be better to have a card with a '?' question mark on it?
The text was updated successfully, but these errors were encountered: