Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a phet-io API call to get the order of the cards in the median screen #283

Closed
samreid opened this issue Jun 20, 2023 · 5 comments
Closed

Comments

@samreid
Copy link
Member

samreid commented Jun 20, 2023

From #204

On the median screen:

Get card values in the order they appear (i.e. kick order) as an array

  • client could get the order of the cards (which is in the order the balls were kicked rather than ordered on the number line)
  • We will add an API call that the user can query on-demand.
@samreid samreid self-assigned this Jun 20, 2023
@samreid
Copy link
Member Author

samreid commented Jun 21, 2023

@marlitas and I wondered if there should be a card container model. If we implement/refactor that, it would impact this issue.

@samreid
Copy link
Member Author

samreid commented Jun 22, 2023

After the commit, you can get the values of the cards like so: await phetioClient.invokeAsync('centerAndVariability.medianScreen.view.accordionBox.cardNodeContainer','getData',[]);. We will have to decide whether we want to move this to the model. And also tagging for #136

@marlitas
Copy link
Contributor

marlitas commented Jul 5, 2023

@matthew-blackman and I reviewed the changes. We just made some small documentation adjustments, everything else looks good. Tested in studio!

@catherinecarter
Copy link
Contributor

Updating the command to:
await phetioClient.invokeAsync('centerAndVariability.medianScreen.model.cardContainerModel','getData',[]);

@samreid
Copy link
Member Author

samreid commented Aug 11, 2023

New command: await phetioClient.invokeAsync('centerAndVariability.medianScreen.model.distanceAccordionBox.cardContainerModel','getData')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants