You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related to #288, for discussion about this REVIEW comment in GraphNode.ts:
// REVIEW: This naming is a bit confusing, and I first thought a GraphNode had a default curveNode// REVIEW: in addition to something else that was provided. Not in place of. It's unclear that the default is// REVIEW: a non-interactive curve, rather than a curve which also happens to be non-interactive.// REVIEW: perhaps just `hasInteractiveCurveNode`?// Whether to create the default CurveNode, which is not interactive
hasDefaultCurveNode?: boolean;
Whether the curve is interactive is really irrelevant in GraphNode; it has no notion of "interaction". What we're trying to describe by this option is whether GraphNode should create the CurveNode that is typically created for a Curve. Would it help to rename hasDefaultCurveNode to createCurveNode, and delete the "which is not interactive" comment, like this?
// Whether to create the default CurveNode for the provided Curve
createCurveNode?: boolean;
The text was updated successfully, but these errors were encountered:
In the above commit, I went ahead and made the change that I suggested above.
Summary, from GraphNode.ts:
// Whether to create a CurveNode for the provided Curve.
createCurveNode?: boolean;
...
// Optional Node that plots the provided Curve, see SelfOptions.createCurveNodeprivatereadonly curveNode?: CurveNode;
...
// Create CurveNode for the provided Curve.if(options.createCurveNode){this.curveNode=newCurveNode(curve,this.chartTransform,{
...
@marlitas if this looks OK to you, please close. Otherwise let's discuss.
Related to #288, for discussion about this REVIEW comment in GraphNode.ts:
Whether the curve is interactive is really irrelevant in GraphNode; it has no notion of "interaction". What we're trying to describe by this option is whether GraphNode should create the CurveNode that is typically created for a Curve. Would it help to rename
hasDefaultCurveNode
tocreateCurveNode
, and delete the "which is not interactive" comment, like this?The text was updated successfully, but these errors were encountered: