-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkbox text labels handling large dynamic strings differently #283
Comments
TangentLineCheckbox, AreaUnderCurveCheckbox, and ReferenceLineCheckbox are in fact handling their strings identically -- they all use RichText, and allow the client to use whatever markup they want. If you change Or change Using RichText anywhere in a sim does bring up the possibililty that the string height (not just its width) may become problematic. Maybe it's a bad assumption, but we assume that translators tests their work, and would notice a case like #283 (comment). But as a bit of defensive programming, I've added Back to @marlitas for review, close if OK. |
Looks much better and feels like a better safe guard. Closing! |
From #268.
One seems to be limiting based on a maxTextWidth and another seems to be using multiple lines in Rich Text to overflow the large string. This is probably due to the fact that "Reference Line" has a space in the string which allows it to be added onto a new line.
I'm unsure how frequently we would run into this situation, but it seemed visually bizarre enough to create an issue to put eyes on it.
The text was updated successfully, but these errors were encountered: