-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation-notes.md #264
Comments
I'll assign this one to myself. |
Assigning to @pixelzoom as well. |
Signed-off-by: Martin Veillette <[email protected]>
replace duplicate doc of query parameters with a link to CalculusGrapherQueryParameters, #264
The section titled Query Parameters duplicated the information in CalculusGrapherQueryParameters.ts, and would be likely to get out of sync. Since dev and QA are used to reading query-parameter schemas, I replaced that section with a link to CalculusGrapherQueryParameters.ts. |
I added a Termninology section that needs to be fleshed out. I think we can keep this very brief. No need to include general math terminology, only sim-specific terms that might not be obvious, and would help someone reading the code. |
Signed-off-by: Martin Veillette <[email protected]>
Signed-off-by: Martin Veillette <[email protected]>
Signed-off-by: Martin Veillette <[email protected]>
Signed-off-by: Martin Veillette <[email protected]>
Signed-off-by: Martin Veillette <[email protected]>
Signed-off-by: Martin Veillette <[email protected]>
#264) Signed-off-by: Martin Veillette <[email protected]>
I added a section about PHET-IO with a short stub. Assigning to @pixelzoom who be able to add something more cogent/relevant. |
Signed-off-by: Martin Veillette <[email protected]>
implementation-notes.md is not delivered with a release. So we can continue to make changes after the release branch is published, and there's no need to cherry-pick to the release branch. |
I went over the implementations-notes. It is a good description and if we compare it to other sim's implementations-notes, we are raising the bar. Closing. |
For #262.
Link: https://github.com/phetsims/calculus-grapher/blob/master/doc/implementation-notes.md
This would be nice to have before official code review, but not essential. Certainly we should have it done before @veillette's sabbatical ends.
The text was updated successfully, but these errors were encountered: