Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstrument Text and RichText #332

Open
pixelzoom opened this issue Jul 26, 2023 · 4 comments
Open

Uninstrument Text and RichText #332

pixelzoom opened this issue Jul 26, 2023 · 4 comments
Labels
dev:phet-io status:blocks-sim-publication status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

... the next time that beers-law-lab and concentration are published. This will be an API change, and will require migration rules.
@zepumph
Copy link
Member

zepumph commented Sep 7, 2023

phetsims/joist#934

@pixelzoom pixelzoom self-assigned this Sep 11, 2023
@pixelzoom
Copy link
Contributor Author

I'm going to do this eagerly, to see how adding migration rules goes. @samreid @zepumph FYI.

@pixelzoom pixelzoom mentioned this issue Sep 11, 2023
Closed
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Sep 11, 2023 •
edited
Loading

I discussed associated derived string Properties with @arouinfar. If they are used to labels a control, or featured, keep them instrumented. If they are are readouts of values that are available elsewhere, remove instrumentation.

pixelzoom added a commit that referenced this issue Sep 11, 2023
@pixelzoom
uninstrument Text and RichText, #332
ea22158
@pixelzoom pixelzoom mentioned this issue Sep 11, 2023
Closed
2 tasks
@pixelzoom
Copy link
Contributor Author

Done in the above commits. This took me 1.5 hours, required consulting with @arouinfar, and required 18 new migration rules (13 TandemFragmentDelete, 5 TandemFragmentRenamed).

This should be reviewed before the sim is republished, so I'll keep this issue open until then.

@pixelzoom pixelzoom removed their assignment Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:phet-io status:blocks-sim-publication status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samreid @pixelzoom @zepumph