Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Concentration" meter body should not be movable. #324

Closed
zepumph opened this issue Feb 2, 2023 · 4 comments
Closed

"Concentration" meter body should not be movable. #324

zepumph opened this issue Feb 2, 2023 · 4 comments
Assignees
@KatieWoe
Labels
dev:phet-io status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Feb 2, 2023 •
edited by pixelzoom
Loading

The probe makes sense to be movable. But in the spirit of #323 and others, let's remove the positionProperty for the meter's body.
pixelzoom added a commit that referenced this issue Feb 2, 2023
@pixelzoom
stationary position for Concentration meter body, #324
0c4bc77
@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 2, 2023 •
edited
Loading

Done in the above commit. The default body position looked reasonable, so that's the position I used.

@arouinfar please verify, close if OK.

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Feb 2, 2023
@pixelzoom pixelzoom changed the title "Concentration" meter should not be movable. "Concentration" meter body should not be movable. Feb 2, 2023
@arouinfar
Copy link
Contributor

Thanks @pixelzoom. Looks good!

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 6, 2023 •
edited
Loading

Reopening to confirm in phetsims/qa#894. It looks like changes I made during dev testing did not get into the 1.7 release branch.

@samreid @matthew-blackman FYI.

@pixelzoom pixelzoom reopened this Feb 6, 2023
@pixelzoom pixelzoom assigned KatieWoe and unassigned arouinfar Feb 6, 2023
@pixelzoom
Copy link
Contributor

Looks OK in 1.7. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KatieWoe KatieWoe

Labels
dev:phet-io status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pixelzoom @zepumph @arouinfar @KatieWoe