Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sodiumChloride.formulaProperty is not a featured property #313

Closed
Nancy-Salpepi opened this issue Jan 30, 2023 · 5 comments
Closed

sodiumChloride.formulaProperty is not a featured property #313

Nancy-Salpepi opened this issue Jan 30, 2023 · 5 comments

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
13.1

Browser
16.2

Problem description
For phetsims/qa#889, when going through the examples https://github.com/phetsims/phet-io-sim-specific/blob/master/repos/beers-law-lab/examples.md, the formulaProperty was a featured element for all of the solutes except for sodium chloride. I had to select "All" under PhET-iO elements in order to see it.

Visuals
Screenshot 2023-01-30 at 5 45 04 PM

@pixelzoom
Copy link
Contributor

@arouinfar adjusted phetioFeatured in #305. She probably missed sodiumChloride.formulaProperty due to the mind-numbing repetative nature of setting up overrides.js.

@arouinfar
Copy link
Contributor

arouinfar commented Jan 30, 2023

She probably missed sodiumChloride.formulaProperty due to the mind-numbing repetative nature of setting up overrides.js.

So true! 😆

We'll need to update the overrides for both beers-law-lab and concentration. @samreid or @zepumph can one of you take care of it?

@arouinfar arouinfar assigned samreid and zepumph and unassigned arouinfar Jan 30, 2023
@zepumph
Copy link
Member

zepumph commented Jan 30, 2023

On it.

@zepumph
Copy link
Member

zepumph commented Jan 30, 2023

Great catch @Nancy-Salpepi. Please confirm fixed in master on studio and feel free to close.

@Nancy-Salpepi
Copy link
Author

Looks good in master.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants