Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update QA credits for 1.7 release #302

Closed
Tracked by #901
, #902
...
pixelzoom opened this issue Dec 16, 2022 · 4 comments
Closed
Tracked by #901
, #902
...

Update QA credits for 1.7 release #302

pixelzoom opened this issue Dec 16, 2022 · 4 comments
Labels
status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

Update QA credits for 1.7 release.

beers-law-lab and concentration share credits via BLLConstants.CREDITS.
pixelzoom added a commit that referenced this issue Feb 2, 2023
@pixelzoom
update QA credits, #302
5473aab
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Feb 2, 2023 •
edited
Loading

At 2/2/2023 Team Phettuccine standup meeting, @Nancy-Salpepi said to make these additions for phetsims/qa#889 and phetsims/qa#891:

Jaron Droder
Emily Miller
Nancy Salpepi
Kathryn Woessner

Done in the above commit.

@pixelzoom
Copy link
Contributor Author

From phetsims/qa#894 (comment), @Nancy-Salpepi said:

Please add Liam Mulhall and Clifford Hardin to the QA credits.

pixelzoom added a commit that referenced this issue Feb 15, 2023
@pixelzoom
update credits, #302
5c7ade3
pixelzoom added a commit that referenced this issue Feb 15, 2023
@pixelzoom
update credits, #302
3c4ff43
pixelzoom added a commit that referenced this issue Feb 15, 2023
@pixelzoom
update credits, #302
f5b29b2
pixelzoom added a commit to phetsims/concentration that referenced this issue Feb 15, 2023
@pixelzoom
https://github.com/phetsims/beers-law-lab/issues/302
8f81327
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Feb 15, 2023 •
edited
Loading

Credits have been updated in master and 1.7 branches.

In addition to the QA updates, I noticed that @arouinfar was not included in the credits, so I added her to "Team".

Ready for verification in the next release. To verify, confirm that the credits look like this for both Beer's Law Lab and Concentration:

screenshot_2313

@pixelzoom pixelzoom mentioned this issue Feb 17, 2023
Closed
17 tasks
@pixelzoom pixelzoom mentioned this issue Feb 17, 2023
Closed
16 tasks
@stemilymill
Copy link

looks good in beers law lab and concentration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @stemilymill