Skip to content

Commit

Permalink
Update to TypeScript 5.5 and typescript-eslint 8.3.0, start using @st…
Browse files Browse the repository at this point in the history
…ylistic/eslint-plugin, see phetsims/chipper#1451
  • Loading branch information
samreid committed Aug 27, 2024
1 parent 35543cf commit f04c0d2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions js/TinyForwardingProperty.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export default class TinyForwardingProperty<ValueType> extends TinyProperty<Valu
}

// API support for setting a Property|ValueType onto the forwarding Property
public setValueOrTargetProperty<NodeType extends NodeLike, NodeParam extends ( NodeType | null )>(
public setValueOrTargetProperty<NodeType extends NodeLike, NodeParam extends( NodeType | null )>(
node: NodeParam, tandemName: string | null, newValueOrTargetProperty: TReadOnlyProperty<ValueType> | ValueType ): void {

if ( ( isTReadOnlyProperty( newValueOrTargetProperty ) ) ) {
Expand Down Expand Up @@ -99,7 +99,7 @@ export default class TinyForwardingProperty<ValueType> extends TinyProperty<Valu
* @param tandemName - null if the Property does not support PhET-iO instrumentation
* @returns the passed in Node, for chaining.
*/
public setTargetProperty<NodeType extends NodeLike, NodeParam extends ( NodeType | null )>(
public setTargetProperty<NodeType extends NodeLike, NodeParam extends( NodeType | null )>(
newTargetProperty: TReadOnlyProperty<ValueType> | null,
node: NodeParam = null as NodeParam,
tandemName: string | null = null
Expand Down
2 changes: 1 addition & 1 deletion js/Validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ type ValueType =
ValueType[] |

// allow Function here since it is the appropriate level of abstraction for checking instanceof
Function; // eslint-disable-line @typescript-eslint/ban-types
Function; // eslint-disable-line @typescript-eslint/no-restricted-types

type ComparableObject = {
equals: ( a: unknown ) => boolean;
Expand Down

0 comments on commit f04c0d2

Please sign in to comment.