Skip to content

Commit

Permalink
Move TODOs to side issue, see #330 and #334
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Oct 2, 2020
1 parent f84b5d1 commit b57391d
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions js/createObservableArray.js
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ const createObservableArray = options => {

init();

//TODO https://github.com/phetsims/axon/issues/330 Move to "prototype" above or drop support
//TODO https://github.com/phetsims/axon/issues/334 Move to "prototype" above or drop support
arrayProxy.reset = () => {
arrayProxy.length = 0;
init();
Expand Down Expand Up @@ -295,8 +295,8 @@ const methods = {

/******************************************
* For compatibility with ObservableArray
* TODO https://github.com/phetsims/axon/issues/330 consider deleting after migration
* TODO https://github.com/phetsims/axon/issues/330 if not deleted, rename 'Item' with 'Element'
* TODO https://github.com/phetsims/axon/issues/334 consider deleting after migration
* TODO https://github.com/phetsims/axon/issues/334 if not deleted, rename 'Item' with 'Element'
*******************************************/

// @public
Expand Down Expand Up @@ -364,11 +364,11 @@ const methods = {
Array.prototype.push.apply( this, shuffled );
},

// TODO https://github.com/phetsims/axon/issues/330 This seems important to eliminate
// TODO https://github.com/phetsims/axon/issues/334 This seems important to eliminate
// @public
getArray: function() { return this; },

//REVIEW https://github.com/phetsims/axon/issues/330 This also seems important to eliminate
//REVIEW https://github.com/phetsims/axon/issues/334 This also seems important to eliminate
// @public
getArrayCopy: function() { return this.slice(); },

Expand Down

0 comments on commit b57391d

Please sign in to comment.