Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT: filter based on "NOT" present #192

Open
zepumph opened this issue Sep 14, 2023 · 3 comments
Open

CT: filter based on "NOT" present #192

zepumph opened this issue Sep 14, 2023 · 3 comments

Comments

@zepumph
Copy link
Member

zepumph commented Sep 14, 2023

From dev meeting today

I think that if the term starts with a !, then we say that it !includes().

@zepumph zepumph self-assigned this Sep 14, 2023
@zepumph
Copy link
Member Author

zepumph commented Sep 14, 2023

I got a temp solution working here, but it doesn't AND terms together correctly.

Working:
!migration will correctly ignore all tests/messages with "migration" in it

Not Working:
!migration -> will show all tests, since every test that has "migration" in it also has "->" in it.

@marlitas, please feel free to use the ! prefix with single words though! I'll get back to this when I can, but it will involve rewriting our filtering logic to remember a precedent for "I specifically told you not to include this thing".

@zepumph zepumph removed their assignment Sep 14, 2023
@marlitas
Copy link
Contributor

This is so amazing and cool. Thanks @zepumph!

@zepumph
Copy link
Member Author

zepumph commented Sep 14, 2023

Ugg, I think I need to keep working on this, it doesn't work at filtering out content in the error message. I want to use this feature more than it currently supports. Reassigning.

@zepumph zepumph self-assigned this Sep 14, 2023
@zepumph zepumph removed their assignment Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants