-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mass over temperature ratio check output #175
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #175 +/- ##
===========================================
+ Coverage 82.73% 82.83% +0.09%
===========================================
Files 54 54
Lines 19345 19384 +39
Branches 1847 1852 +5
===========================================
+ Hits 16005 16056 +51
+ Misses 3340 3328 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should also print the same ratios for the true vacuum? And should we save it in the output file or is just a print sufficient?
I'm not sure what this ratio would mean in the true vacuum. My understanding is that it is a measure of how good our high-temperature expansion should work, with the false vacuum as the initial position of the transition, that is why I check the false vacuum thermal masses. |
For each derived characteristic temperature, add one line of output to
LoggingLevel::TransitionDetailed
that informs the user about the thermal mass over temperature ratios at this temperature.