Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mass over temperature ratio check output #175

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

lisabiermann
Copy link
Collaborator

For each derived characteristic temperature, add one line of output to LoggingLevel::TransitionDetailed that informs the user about the thermal mass over temperature ratios at this temperature.

@lisabiermann lisabiermann added the enhancement New feature or request label Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.83%. Comparing base (0478ad4) to head (3ac2b2b).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/transition_tracer/transition_tracer.cpp 89.74% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #175      +/-   ##
===========================================
+ Coverage    82.73%   82.83%   +0.09%     
===========================================
  Files           54       54              
  Lines        19345    19384      +39     
  Branches      1847     1852       +5     
===========================================
+ Hits         16005    16056      +51     
+ Misses        3340     3328      -12     
Flag Coverage Δ
unittests 82.83% <89.74%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@vollous vollous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should also print the same ratios for the true vacuum? And should we save it in the output file or is just a print sufficient?

src/transition_tracer/transition_tracer.cpp Outdated Show resolved Hide resolved
@lisabiermann
Copy link
Collaborator Author

Do you think we should also print the same ratios for the true vacuum? And should we save it in the output file or is just a print sufficient?

I'm not sure what this ratio would mean in the true vacuum. My understanding is that it is a measure of how good our high-temperature expansion should work, with the false vacuum as the initial position of the transition, that is why I check the false vacuum thermal masses.
For the moment, I would leave it as optional print statement. But I'm not against adding it as output in the future.

@lisabiermann lisabiermann merged commit 5694adc into develop Dec 13, 2024
8 checks passed
@lisabiermann lisabiermann deleted the highT_validity_check branch December 13, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants