Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition on "calc temp at false vac fraction()" #148

Closed

Conversation

vollous
Copy link
Collaborator

@vollous vollous commented Jun 24, 2024

No description provided.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.32%. Comparing base (d1d5687) to head (1a84802).
Report is 2 commits behind head on master.

Files Patch % Lines
src/bounce_solution/bounce_solution.cpp 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   83.33%   83.32%   -0.01%     
==========================================
  Files          54       54              
  Lines       18766    18769       +3     
  Branches     1850     1848       -2     
==========================================
+ Hits        15638    15640       +2     
- Misses       3128     3129       +1     
Flag Coverage Δ
unittests 83.32% <88.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vollous vollous closed this Jun 24, 2024
@vollous vollous deleted the fix-condition-on-"CalcTempAtFalseVacFraction()" branch June 24, 2024 12:38
@vollous vollous restored the fix-condition-on-"CalcTempAtFalseVacFraction()" branch June 24, 2024 12:38
@vollous vollous deleted the fix-condition-on-"CalcTempAtFalseVacFraction()" branch June 24, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant