-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case Sensitivity of identifiers in REST API calls #57
Comments
We also have this problem - when creating serviceGroup from web UI which name has uppercase letters it is automatically converted to lowercase. In REST calls it is not ant throws exceptions |
What identifier scheme are you using? simple or oasis? |
peppol |
Okay thanks - which REST API. I tried the "PUT" with the "serviceGroup" interface and it works fine. |
Ok, trying to call serviceGroup creation by PUT with curl with given paylod: curl -n -X PUT -H 'Content-Type: application/xml;charset=UTF-8' -d '9945:idTEST' http://smptest/iso6523-actorid-upis%3A%3A9945%3AidTEST I got response: Not found: ServiceGroup Inconsistency. The URL points to iso6523-actorid-upis::9945:idtest whereas the ServiceGroup contains [ParticipantIdentifierType@0x3ef98a80: value=9945:idTEST; scheme=iso6523-actorid-upis] at http://smptest/iso6523-actorid-upis::9945:idTEST Tomcat log: [2018-10-30T15:28:07,681] [SMP-SERVER] [INFO ] [ajp-nio-8209-exec-1] [SMP REST API] PUT /iso6523-actorid-upis::9945:idTEST ==> [ServiceGroupType@0x7e3cf026: participantIdentifier=[ParticipantIdentifierType@0x1699348a: value=9945:idTEST; scheme=iso6523-actorid-upis]; serviceMetadataReferenceCollection=null; extension=null] -- com.helger.peppol.smpserver.restapi.SMPServerAPI.saveServiceGroup(SMPServerAPI.java:291) |
Thanks for the reminder. Is fixed in v5.0.8 |
I added myself some test scripts as well - https://github.com/phax/peppol-smp-server/tree/master/test-scripts/localhost_90 |
It appears that when the identifier scheme of the participant is not the PEPPOL one, then the identifier value is treated as case sensitive.
There should be an option in the configuration (or some other means) to choose/configure how these identifiers are treated. In rest api calls.
Affects server, might affect also client in inverse: A .tolowercase() is applied in the identifiers before the ServiceGroup or ServiceMetadata Rest api calls.
The text was updated successfully, but these errors were encountered: