Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phaser.Weapon#fireRateVariance without effect #2715

Closed
noseglid opened this issue Aug 24, 2016 · 2 comments
Closed

Phaser.Weapon#fireRateVariance without effect #2715

noseglid opened this issue Aug 24, 2016 · 2 comments

Comments

@noseglid
Copy link
Contributor

First off, thanks for an awesome game engine. I've just recently started using it and made so much progress in so short time due to the great examples and documentation as well as the very flexible but extensive framework!

This Issue is about (delete as applicable)

  • A bug in the API

Setting fireRateVariance does not have any effect.

I've tracked the error to when _nextFire in the weapon plugin is set. I'm guessing this needs some similar treatment as with the bulletSpeedVariance.
photonstorm added a commit that referenced this issue Aug 25, 2016
@photonstorm
The Weapon.fireRateVariance property was never taken into account int…
19dbd8b 
…ernally. It's now applied to the firing rate correctly (thanks @noseglid #2715)
@photonstorm
Copy link
Collaborator

Thanks for submitting this issue. We have fixed this, and the fix has been pushed to the dev branch.

@noseglid
Copy link
Contributor Author

Wow, quick turnaround!
👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@photonstorm @noseglid