Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/827 10.8.0 drupal docs #828

Merged
merged 4 commits into from
Jun 3, 2020

Conversation

Jwaxo
Copy link
Contributor

@Jwaxo Jwaxo commented Jun 2, 2020

Updates issue #827

Issue Description

Adds a readme for how to install the app for Drupal 8 usage, which resolves some of Issue #827

Summary of Changes

  • Moves the Drupal theme files located in apps/drupal/theme to a subfolder, so that it matches the setup in apps/drupal/module.
  • Adds instructions on how to use the files within the apps/drupal folder to set up a Drupal installation of Particle. If anything here is erroneous, feel free to update, and please tell me so that I can fix my own installation.

Additionally, this issue queue references a nonexistent develop branch.

@Jwaxo Jwaxo requested review from illepic and jryanconklin June 2, 2020 21:15
Copy link
Contributor

@jryanconklin jryanconklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hesitate to add the Drupal theme pieces a further directory down in apps since "decoupled" Particle might not be the default approach for some projects. Original intent being you'd completely move that directory and rename if you did intend to decouple.

That said, if you feel strongly about it I understand. You will need to update the dist paths in Drupal's yml files (info.yml and libraries).

@illepic
Copy link
Contributor

illepic commented Jun 2, 2020

Possible idea to get out of depth-a-palooza. :

- apps
-- drupal
--- particle_helper_module
---- particle_helper.info.yml, module stuff
--- particle_theme
---- particle.info.yml, theme files
--- particle_assets
---- index.js, webpack, eslint, etc

What do yall think?

@jryanconklin jryanconklin merged commit d8d652e into phase2:master Jun 3, 2020
madhaze added a commit that referenced this pull request Jun 8, 2020
* master:
  Update generator demo yml files to have Demo info above content. (#825)
  SVG with Tailwind. (#829)
  TASK :: Revise Drupal + Pattern Lab Directory Structure (#831)
  Issue/827 10.8.0 drupal docs (#828)

# Conflicts:
#	apps/pl-default/pattern-lab/_patterns/02-molecules-demo/accordion/accordions.twig
#	apps/pl-default/pattern-lab/_patterns/02-molecules-demo/accordion/accordions.yml
#	apps/pl-default/pattern-lab/_patterns/02-molecules-demo/accordion/index.js
madhaze added a commit that referenced this pull request Jun 8, 2020
* master:
  Update generator demo yml files to have Demo info above content. (#825)
  SVG with Tailwind. (#829)
  TASK :: Revise Drupal + Pattern Lab Directory Structure (#831)
  Issue/827 10.8.0 drupal docs (#828)

# Conflicts:
#	apps/pl-default/pattern-lab/_patterns/02-molecules-demo/tabs/index.js
#	apps/pl-default/pattern-lab/_patterns/02-molecules-demo/tabs/tabss.twig
#	apps/pl-default/pattern-lab/_patterns/02-molecules-demo/tabs/tabss.yml
madhaze added a commit that referenced this pull request Jun 8, 2020
* master:
  Update all deps. (#835)
  Update generator demo yml files to have Demo info above content. (#825)
  SVG with Tailwind. (#829)
  TASK :: Revise Drupal + Pattern Lab Directory Structure (#831)
  Issue/827 10.8.0 drupal docs (#828)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants