SpCodeInteractionModel: add compile and test it #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So do not rely on `respondsTo:` returning false, it's cleaner this way
…pilation services
…st (nil was used previously)
…and ivar mutation
|
Tests are OK (I'm not responsible for class comments as I did not add a class) |
MarcusDenker
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pharo-project/pharo#13498 did solve a regression with dolt evaluation in the debugger.
This PR move a
compilerhelper to the code interaction model (used by SpCodePresenter) and add (and fix) tests to prevent future issues.Because of the regression, I assume that #13498 should be merged first.